From 2490d55bcce733e118de9660e0324a6ce57c6426 Mon Sep 17 00:00:00 2001 From: Kyle Meyer Date: Mon, 26 Dec 2022 18:06:28 -0500 Subject: km/magit-github-diff-link: Dereference to commit Giving tag OID won't work on GitHub. --- lisp/km-magit.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/km-magit.el b/lisp/km-magit.el index 92ba112..204bddb 100644 --- a/lisp/km-magit.el +++ b/lisp/km-magit.el @@ -1143,8 +1143,8 @@ function." ;; This always converts to commits IDs. It could try to map ;; refnames to the appropriate GitHub link (including remotes ;; to forks), but I don't have much need for it at the moment. - (let ((rev1 (magit-rev-parse (match-string 1 magit-buffer-range))) - (rev2 (magit-rev-parse (match-string 3 magit-buffer-range)))) + (let ((rev1 (magit-commit-p (match-string 1 magit-buffer-range))) + (rev2 (magit-commit-p (match-string 3 magit-buffer-range)))) (format "%s/compare/%s...%s" (or (km/magit-github-url) "") rev1 rev2))))) -- cgit v1.2.3