diff options
| author | Rob Herring <robh@kernel.org> | 2022-03-31 14:53:46 -0500 |
|---|---|---|
| committer | Konstantin Ryabitsev <konstantin@linuxfoundation.org> | 2022-06-14 16:24:08 -0400 |
| commit | c95e4d16d87c7c71589c64b1ac94973b354d0820 (patch) | |
| tree | 85cd848d56dbcc16c092b251dcc5aeb422ca09cf /hooks | |
| parent | bfe5df6694c8115fa8402943b125c6e47c8eec08 (diff) | |
| download | b4-c95e4d16d87c7c71589c64b1ac94973b354d0820.tar.gz | |
am: Fix broken guessbranch handling
b4's usage of git-log '--branches' option is broken. The option takes a
glob pattern *only* and must have an '=', but b4 ends up passing
'--branches <guessbranch>' to git-log. This will kind of work, but is
not checking only 'guessbranch'. For example, these 3 commands all do
something different:
git log -1 --branches=master
git log -1 --branches master
git log -1 --branches=*aster
A maintainer wanting to apply a patch or series likely has a small set of
known branches they apply patches to. Using a glob pattern is not a good
fit for that. Instead, allow --guess-branch to be repeated and to take
fixed refs.
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Link: https://lore.kernel.org/r/20220331195346.1384515-1-robh@kernel.org
Diffstat (limited to 'hooks')
0 files changed, 0 insertions, 0 deletions