summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Ryabitsev <konstantin@linuxfoundation.org>2020-07-06 18:06:30 -0400
committerKonstantin Ryabitsev <konstantin@linuxfoundation.org>2020-07-06 18:06:30 -0400
commit857797f0bc1809e8af8ae5a1a31e3551742ee31b (patch)
treed6577505f1d45a0e3df11a28635f11f26fdd01a0
parent55913ca66ea666f24693b056260c5596d88a0157 (diff)
downloadb4-857797f0bc1809e8af8ae5a1a31e3551742ee31b.tar.gz
Fix crash when -c used with incomplete series
Return early if we don't have a cover letter or patch 1/X to use as basis for the subject-based query. Reported-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
-rw-r--r--b4/mbox.py4
1 files changed, 4 insertions, 0 deletions
diff --git a/b4/mbox.py b/b4/mbox.py
index d40c3df..2391405 100644
--- a/b4/mbox.py
+++ b/b4/mbox.py
@@ -365,6 +365,10 @@ def get_extra_series(mboxfile, direction=1, wantvers=None, nocache=False):
# A patch/series without a cover letter
base_msg = msg
+ if base_msg is None:
+ logger.debug('Could not find cover of 1st patch in mbox')
+ mbx.close()
+ return
# Get subject info from base_msg again
lsub = b4.LoreSubject(base_msg['Subject'])
if not len(lsub.prefixes):